Backport of [NET-5916] Fix locality-aware routing config and tests (CE) to release/1.17.0 #19487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/cli
zalimeni
added
pr/no-changelog
zalimeni
requested review from
erichaberkorn,
david-yu,
NicoletaPopoviciu and
hashi-derek
erichaberkorn
approved these changes
Nov 2, 2023
NicoletaPopoviciu
approved these changes
Nov 2, 2023
david-yu
approved these changes
Nov 2, 2023
hashi-derek
deleted the
backport/derekm/NET-5916/vm-locality/release-1.17.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is manually generated from #19483 to be assessed for backporting.
The below text is copied from the body of the original PR.
This also backports the test fix from #19476, which is required for CI to pass. (cc @analogue )
Description
This change fixes several issues with configuring and using the new locality-aware routing feature introduced in 1.17.
localityin addition to HTTP endpointsNodeService(agent configuration) to service proxies occurs when not explicitly specified in service registrationA follow-up change will align docs with proper user flows as noted in the ticket.
Testing & Reproduction steps
PR Checklist