Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Regen expired test certs into release/1.17.x #19479

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19476 to be assessed for backporting due to the inclusion of the label backport/1.17.

The below text is copied from the body of the original PR.


Description

=== FAIL: tlsutil TestConfigurator_OutgoingInternalRPCWrapper/VerifyServerHostname_=_false (re-run 3) (0.00s)
    config_test.go:773: 
        	Error Trace:	/home/runner/work/consul/consul/tlsutil/config_test.go:773
        	Error:      	Received unexpected error:
        	            	x509: certificate has expired or is not yet valid: current time 2023-11-02T02:24:15Z is after 2023-11-01T15:17:35Z
        	Test:       	TestConfigurator_OutgoingInternalRPCWrapper/VerifyServerHostname_=_false

Testing & Reproduction steps

Test passes locally.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/spatel/fix-expired-test-certs/preferably-golden-lacewing branch from 481ab8f to 78e4417 Compare November 2, 2023 15:26
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/spatel/fix-expired-test-certs/preferably-golden-lacewing branch from 3ab279f to e6570a0 Compare November 2, 2023 15:26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit e557c80 into release/1.17.x Nov 2, 2023
87 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/spatel/fix-expired-test-certs/preferably-golden-lacewing branch November 2, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants