Backport of [NET-6221] Ensure LB policy set for locality-aware routing (CE) into release/1.17.0 #19290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
added
pr/no-changelog
NicoletaPopoviciu
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
LGTM, compared w original PR https://github.com/hashicorp/consul/pull/19283/files
david-yu
approved these changes
Oct 19, 2023
zalimeni
deleted the
backport/zalimeni/net-6221-add-missing-overprovisioningfactor-locality-routing/1.17.0-manual
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is manually generated from #19283 for backporting to the
1.17.0GA release branch.The below text is copied from the body of the original PR.
overprovisioningFactorshould be overridden with the expected value (100,000) when there are multiple endpoint groups. Update code and tests to enforce this.This is an Enterprise feature. This commit represents the CE portions of the change; tests are added in the corresponding
consul-enterprisechange.This will need to be manually backported to
release/1.17.0to be included for GA.PR Checklist