Backport of build(docker): always publish full and minor version tags for dev images into release/1.15.x #19280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/dans/fix-docker-dev-tag/merely-sound-emu
branch
from
e3e0930
to
a06ddfc
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
Oct 18, 2023
DanStough
force-pushed
the
backport/dans/fix-docker-dev-tag/merely-sound-emu
branch
from
174dab1
to
cae6f41
Compare
DanStough
requested review from
dekimsey and
claire-labry
and removed request for
a team
… for dev images into release/1.17.x (#19282) backport of commit c6bb4a5 Co-authored-by: DanStough <[email protected]>
DanStough
force-pushed
the
backport/dans/fix-docker-dev-tag/merely-sound-emu
branch
from
cae6f41
to
1177043
Compare
DanStough
deleted the
backport/dans/fix-docker-dev-tag/merely-sound-emu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19278 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@DanStough
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Always publishing full and minor-only tag versions. This accomplishes two goals:
For long-running release branches, .x, always publish a minor-only tag so that tests use the latest version (e.g. 1.17-dev)
For point release branches, .0, always publish the full version so we can fix this for testing purposes (e.g. 1.17.0)
Links
Similar to hashicorp/consul-dataplane#306
Overview of commits