Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: clarify the requriment for cross-partition network into release/1.16.x #19080

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19052 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@huikang
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "ff2468543e54ea3819a859fe25382a44bfb972d1", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

As pointed by @hashi-derek , mesh-gateway has to be exported for cross-partition network. We don't have any tutorial on this use case, so put a note in the general introduction to Admin partition.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 5, 2023
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/doc-fix-missing-step-partition/ultimately-rare-snail branch 2 times, most recently from 7b9db20 to bc38223 Compare October 5, 2023 15:30
@vercel vercel bot temporarily deployed to Preview – consul October 5, 2023 15:31 Inactive
@huikang huikang marked this pull request as ready for review October 5, 2023 15:42
@huikang huikang requested a review from a team as a code owner October 5, 2023 15:42
@huikang huikang merged commit 19bb5db into release/1.16.x Oct 5, 2023
49 of 50 checks passed
@huikang huikang deleted the backport/doc-fix-missing-step-partition/ultimately-rare-snail branch October 5, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants