-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow connections through Terminating Gateways from peered clusters NET-3463 #18959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missylbytes
changed the title
Allow connections through Terminating Gateways from peered clusters
Allow connections through Terminating Gateways from peered clusters NET-3463
Sep 26, 2023
missylbytes
added
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
backport/1.16
This release series is no longer active on CE. Use backport/ent/1.16.
labels
Sep 29, 2023
sarahalsmiller
approved these changes
Sep 29, 2023
@andrewstucki should I add a golden file for this change? If so, can we pair on that process? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
t-eckert
force-pushed
the
termgw-httpfilters
branch
from
October 5, 2023 18:04
251f112
to
b9a2e0f
Compare
nathancoleman
pushed a commit
that referenced
this pull request
Oct 5, 2023
…ET-3463 (#18959) * Add InboundPeerTrustBundle maps to Terminating Gateway * Add notify and cancelation of watch for inbound peer trust bundles * Pass peer trust bundles to the RBAC creation function * Regenerate Golden Files * add changelog, also adds another spot that needed peeredTrustBundles * Add basic test for terminating gateway with peer trust bundle * Add intention to cluster peered golden test * rerun codegen * update changelog * really update the changelog --------- Co-authored-by: Melisa Griffin <[email protected]>
nathancoleman
pushed a commit
that referenced
this pull request
Oct 5, 2023
…d clusters NET-3463 into release/1.15.x (#19091) Allow connections through Terminating Gateways from peered clusters NET-3463 (#18959) * Add InboundPeerTrustBundle maps to Terminating Gateway * Add notify and cancelation of watch for inbound peer trust bundles * Pass peer trust bundles to the RBAC creation function * Regenerate Golden Files * add changelog, also adds another spot that needed peeredTrustBundles * Add basic test for terminating gateway with peer trust bundle * Add intention to cluster peered golden test * rerun codegen * update changelog * really update the changelog --------- Co-authored-by: Thomas Eckert <[email protected]> Co-authored-by: Melisa Griffin <[email protected]>
nathancoleman
pushed a commit
that referenced
this pull request
Oct 5, 2023
…ET-3463 (#18959) * Add InboundPeerTrustBundle maps to Terminating Gateway * Add notify and cancelation of watch for inbound peer trust bundles * Pass peer trust bundles to the RBAC creation function * Regenerate Golden Files * add changelog, also adds another spot that needed peeredTrustBundles * Add basic test for terminating gateway with peer trust bundle * Add intention to cluster peered golden test * rerun codegen * update changelog * really update the changelog --------- Co-authored-by: Melisa Griffin <[email protected]>
nathancoleman
pushed a commit
that referenced
this pull request
Oct 5, 2023
…d clusters NET-3463 into release/1.16.x (#19092) Allow connections through Terminating Gateways from peered clusters NET-3463 (#18959) * Add InboundPeerTrustBundle maps to Terminating Gateway * Add notify and cancelation of watch for inbound peer trust bundles * Pass peer trust bundles to the RBAC creation function * Regenerate Golden Files * add changelog, also adds another spot that needed peeredTrustBundles * Add basic test for terminating gateway with peer trust bundle * Add intention to cluster peered golden test * rerun codegen * update changelog * really update the changelog --------- Co-authored-by: Thomas Eckert <[email protected]> Co-authored-by: Melisa Griffin <[email protected]>
jmurret
pushed a commit
that referenced
this pull request
Oct 12, 2023
…ET-3463 (#18959) * Add InboundPeerTrustBundle maps to Terminating Gateway * Add notify and cancelation of watch for inbound peer trust bundles * Pass peer trust bundles to the RBAC creation function * Regenerate Golden Files * add changelog, also adds another spot that needed peeredTrustBundles * Add basic test for terminating gateway with peer trust bundle * Add intention to cluster peered golden test * rerun codegen * update changelog * really update the changelog --------- Co-authored-by: Melisa Griffin <[email protected]>
4 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
backport/1.16
This release series is no longer active on CE. Use backport/ent/1.16.
theme/envoy/xds
Related to Envoy support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables services in one datacenter to access resources through a terminating gateway in another datacenter over cluster peering.
In the diagram below, previously only
backend
could reachGoogle
. Nowfrontend
can also reachGoogle
.Testing & Reproduction steps
I tested this using Kubernetes with this set of configuration files.
Links
PR Checklist