Backport of NET-5187: Upgrade test timeout due to log producer errors into release/1.16.x #18472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/NET-5187/safely-vital-hookworm
branch
from
a97515d
to
fbadc31
Compare
hc-github-team-consul-core
force-pushed
the
backport/NET-5187/safely-vital-hookworm
branch
from
6e0864b
to
e13469f
Compare
github-team-consul-core-pr-approver
approved these changes
Aug 15, 2023
hc-github-team-consul-core
deleted the
backport/NET-5187/safely-vital-hookworm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18461 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
If
--follow-log=trueseveral upgrade tests timeout after passing. This was as a result of container failing to stop due to log producer not being stopped before container restartSOLUTION
To restart a container - sidecar:
Then container can be stopped and terminated gracefully.
Testing & Reproduction steps
Links
PR Checklist
Overview of commits