Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: K8s secondary DC requirements into release/1.16.x #18386

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18280 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@trujillo-adam
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "e46f988cd997572d7d6ff8d67065a9c6cc1febee", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

This PR responds to a request to highlight the Kubernetes WAN Federation requirement that when ACLs are enabled, the Kube API of the secondary datacenters must be routable from the primary datacenter.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/k8s-federation-requirements/certainly-accepted-mallard branch 2 times, most recently from 2915972 to 1dcbf9b Compare August 4, 2023 20:27
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/k8s-federation-requirements/certainly-accepted-mallard branch from 9f3b768 to c1b83b5 Compare August 4, 2023 20:27
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Aug 4, 2023
@trujillo-adam trujillo-adam marked this pull request as ready for review September 18, 2023 19:25
@trujillo-adam trujillo-adam requested a review from a team as a code owner September 18, 2023 19:25
@trujillo-adam trujillo-adam enabled auto-merge (squash) September 18, 2023 19:26
@trujillo-adam trujillo-adam merged commit d732000 into release/1.16.x Sep 18, 2023
80 checks passed
@trujillo-adam trujillo-adam deleted the backport/docs/k8s-federation-requirements/certainly-accepted-mallard branch September 18, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants