Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add first integration test for jwt auth with intentions into release/1.16.x #18029

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18005 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@roncodingenthusiast
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

  • Introduces an integration test for JWT auth with intentions. The test spins up a static-server and client, write a jwt-provider and intention, verifies that this blocks/allows request as expected.
  • Inverting rbac filters and jwt-auth filters because the jwt-auth filters are supposed to forward data to the rbac filters. So when rbac get evaluated first, it will be doing so without the potential jwt-auth filter data

Testing & Reproduction steps

$ make test-compat-integ-setup
$ cd ./test/integration/consul-container
test/integration/consul-container$ go test -v ./test/jwtauth -timeout 2m

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-4277-latest/privately-normal-coyote branch 2 times, most recently from 6c2b095 to de9dd31 Compare July 6, 2023 11:27
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@roncodingenthusiast roncodingenthusiast force-pushed the backport/NET-4277-latest/privately-normal-coyote branch from c6cc2cc to 9ad7ff4 Compare July 6, 2023 11:34
@roncodingenthusiast roncodingenthusiast marked this pull request as ready for review July 6, 2023 11:54
@roncodingenthusiast roncodingenthusiast merged commit c3c28c4 into release/1.16.x Jul 6, 2023
@roncodingenthusiast roncodingenthusiast deleted the backport/NET-4277-latest/privately-normal-coyote branch July 6, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants