Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add generic experiments configuration and use it to enable catalog v2 resources into release/1.16.x #17655

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17604 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

We wanted the next gen catalog as resources feature to be disabled by default for now with the option to enable it. I could have added another boolean flag to enable like we have done for some other features but instead decided to rip off of vault and add an experiments config setting.

The advantages of this approach are:

  1. We don't have to keep adding one-off config changes every time we want to introduce an experimental feature.
  2. For features that will eventually be always on, we don't want to maintain the one-off booleans. Using a string slice allows us to simply ignore older names.

Testing & Reproduction steps

  • Dev Server - this enables the catalog-resources experiment by default
  • Non-Dev Server - this will have the catalog resources disabled by default
  • Non-Dev Server + experiments = ["catalog-resources"] - this enables the experiment

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/catalog-v2/feature-flag/randomly-decent-gnat branch from 8bf7391 to 54f7681 Compare June 12, 2023 15:33
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/catalog-v2/feature-flag/randomly-decent-gnat branch from 77fd376 to 14cf0bb Compare June 12, 2023 15:33
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) June 12, 2023 15:33
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label Jun 12, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit 296128f into release/1.16.x Jun 12, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/catalog-v2/feature-flag/randomly-decent-gnat branch June 12, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/config Relating to Consul Agent configuration, including reloading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants