Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of docs: add note about Nomad support for Consul 1.13.8 into release/1.14.x #17549

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Backport of docs: add note about Nomad support for Consul 1.13.8 into release/1.14.x #17549

merged 1 commit into from
Jun 1, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17512 to be assessed for backporting due to the inclusion of the label backport/1.14.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@david-yu
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

Description

Document the impact of #17503 for Nomad users.

This was a general description, but feel free to modify the text as you see fit.

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs-upgrade-node-1-13-8/finally-gorgeous-bonefish branch 2 times, most recently from 8d9e0e8 to 53ff89e Compare June 1, 2023 22:09
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs-upgrade-node-1-13-8/finally-gorgeous-bonefish branch from 53ff89e to 8d9e0e8 Compare June 1, 2023 22:09
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jun 1, 2023
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 1, 2023 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 1, 2023 22:20 Inactive
@david-yu david-yu marked this pull request as ready for review June 1, 2023 22:54
@david-yu david-yu requested a review from a team as a code owner June 1, 2023 22:54
@david-yu david-yu merged commit bfffdc2 into release/1.14.x Jun 1, 2023
@david-yu david-yu deleted the backport/docs-upgrade-node-1-13-8/finally-gorgeous-bonefish branch June 1, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees

@david-yu david-yu

Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @david-yu @lgfa29