Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of hoststats: add package for collecting host statistics including cpu memory and disk usage into release/1.15.x #17532

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17038 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

This PR adds the ability for Consul to report host statistics through go-metrics. These metrics include cpu utilization by core and in aggregate, system memory usage and disk usage for the disk backing the configured data_dir.

Testing & Reproduction steps

Tests were added to assert cpu utilization calculation is performed accurately. Manual testing was performed on linux and darwin to ensure reported host stats values were accurate.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner May 31, 2023 17:36
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/telemetry/host-stats/mistakenly-champion-piranha branch from e948fd2 to 5385903 Compare May 31, 2023 17:36
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/telemetry/host-stats/mistakenly-champion-piranha branch from 5f5ae46 to c715151 Compare May 31, 2023 17:36
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) May 31, 2023 17:36
@github-actions github-actions bot added theme/config Relating to Consul Agent configuration, including reloading theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics type/docs Documentation needs to be created/updated/clarified labels May 31, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul May 31, 2023 17:49 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit f9d3f8a into release/1.15.x May 31, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/telemetry/host-stats/mistakenly-champion-piranha branch May 31, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/config Relating to Consul Agent configuration, including reloading theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants