Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Rename hcp-metrics-collector to consul-telemetry-collector (#17327) #17412

Merged
merged 1 commit into from
May 19, 2023
Merged

[Backport] Rename hcp-metrics-collector to consul-telemetry-collector (#17327) #17412

merged 1 commit into from
May 19, 2023

Conversation

Achooo
Copy link
Contributor

@Achooo Achooo commented May 18, 2023

  • Rename hcp-metrics-collector to consul-telemetry-collector

  • Fix docs

  • Fix doc comment

Description

Backporting manually the changes in PR #17327
The backport PR that failed: #17386

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@clly @Achooo
Rename hcp-metrics-collector to consul-telemetry-collector (#17327)
42d2d2f 
* Rename hcp-metrics-collector to consul-telemetry-collector

* Fix docs

* Fix doc comment

---------

Co-authored-by: Ashvitha Sridharan <[email protected]>
@Achooo Achooo requested a review from a team as a code owner May 18, 2023 20:31
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/envoy/xds Related to Envoy support type/docs Documentation needs to be created/updated/clarified labels May 18, 2023
@Achooo Achooo requested a review from curtbushko May 18, 2023 20:31
@Achooo Achooo mentioned this pull request May 18, 2023
Closed
4 tasks
curtbushko
curtbushko approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Achooo
Copy link
Contributor Author

Achooo commented May 18, 2023

@curtbushko lightning speed review, thanks! ⚡

@Achooo Achooo merged commit 87d3f45 into release/1.15.x May 19, 2023
@Achooo Achooo deleted the backport/f/metrics-collector-rename/achooo-manual branch May 19, 2023 15:33
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

Assignees
No one assigned
Labels
pr/no-backport theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/envoy/xds Related to Envoy support type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Achooo @curtbushko @clly