Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update consul-k8s install command so it is valid #17310

Merged
merged 2 commits into from
May 11, 2023
Merged

Update consul-k8s install command so it is valid #17310

merged 2 commits into from
May 11, 2023

Conversation

im2nguyen
Copy link
Contributor

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@im2nguyen im2nguyen added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.14 backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels May 11, 2023
@im2nguyen im2nguyen marked this pull request as ready for review May 11, 2023 18:00
@im2nguyen im2nguyen requested a review from a team as a code owner May 11, 2023 18:00
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label May 11, 2023
boruszak
boruszak approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Approving on behalf of consul-docs

@im2nguyen im2nguyen merged commit 30eee13 into main May 11, 2023
@im2nguyen im2nguyen deleted the docs/update-install-consul-k8s branch May 11, 2023 18:55
This was referenced May 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boruszak boruszak boruszak approved these changes

Assignees
No one assigned
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@im2nguyen @boruszak