upgrade test: use docker.mirror.hashicorp.services to avoid docker login

[huikang]

Description

Use docker image from docker.mirror.hashicorp.services to avoid docker login in GHA

Also add image name as parameter to cluster.StandardUpgrade(utils.GetTargetImageName(), tc.targetVersion), because the image we upgrade to is consul:locally, which is different than the latest image docker.mirror.hashicorp.services/docker:1.15 for example.

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

[huikang]

@loshz , this is where we change the docker image to use docker.mirror.hashicorp.services. I am not sure where to remove the docker login since it seems needed to pull vault image. Please advise.

[loshz]

I pushed a change in 81e3c44

[huikang]

@loshz , we might just need to remove the docker login in CI: #17193

[loshz]

we might just need to remove the docker login in CI: #17193

If we’re removing the Dockerhub login, then we need to pull images from the HCP registry instead as we could be hit by quota limits if we have a lot of CI jobs running.

[loshz]

The Docker changes LGTM, but I'm unsure if we need to add the image parameter in this PR? I'd like this to be as atomic as possible, so could we do that in a separate PR once we can validate the removal of Docker Hub in GHA works as expected?

[huikang]

The Docker changes LGTM, but I'm unsure if we need to add the image parameter in this PR? I'd like this to be as atomic as possible, so could we do that in a separate PR once we can validate the removal of Docker Hub in GHA works as expected?

@loshz , are you referring to the changes in other files for upgrade test? If so, these changes are necessary since the latest image and target image name will be different:

• Before: both uses consul as the image name
• After: the latest image will be docker.mirror.hashicorp.services/consul:v1.15. Since the target image (the version to upgrade to) is built locally, the makefile uses the image name of consul:local. Without the change, the container uses the image from the previous image - docker.mirror.hashicorp.services/consul:local, which doesn't exist in this case.

consul/test/integration/consul-container/libs/cluster/agent.go

Lines 73 to 75 in 90fc9bd

	func (c *Config) DockerImage() string {
	return utils.DockerImage(c.Image, c.Version)
	}

So I think these changes are needed for make CI passed.

[loshz]

@huikang ah, I see! This LGTM - thanks for fixing the issue.

[huikang]

@loshz , actually your early suggestions make sense. So I split the change to upgrade test into a separate PR #17226. Given @NiniOak has approved the part in this one, could you help approve #17226?

After that, I can update this one to an atomic change in GHA config file. Thanks.

[loshz]

@loshz , actually your early suggestions make sense. So I split the change to upgrade test into a separate PR #17226. Given @NiniOak has approved the part in this one, could you help approve #17226?

After that, I can update this one to an atomic change in GHA config file. Thanks.

Ok, sounds good! So we're going to merge #17226 first and then this one?

[huikang]

Ok, sounds good! So we're going to merge #17226 first and then this one?

Yes, that's correct. After merging #17226, the change in this PR will be downsized to only .github/workflows/test-integrations.yml.