TProxy integration test #17103
Merged
TProxy integration test #17103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
added
pr/no-changelog
pglass
commented
Apr 24, 2023
test/integration/consul-container/libs/service/assets/Dockerfile-consul-envoy
Outdated
Show resolved
Hide resolved
pglass
commented
Apr 24, 2023
test/integration/consul-container/libs/service/assets/Dockerfile-consul-envoy
Show resolved
Hide resolved
pglass
commented
Apr 24, 2023
| "-exclude-inbound-port", "8302", | ||
| "-exclude-inbound-port", "8500", | ||
| "-exclude-inbound-port", "8502", | ||
| "-exclude-inbound-port", "8600", |
There was a problem hiding this comment.
These are all the Consul client ports that needed to be excluded from traffic redirection rules because Consul and Envoy share a network namespace.
pglass
commented
Apr 24, 2023
| Mode: mgwMode, | ||
| }, | ||
| }}, | ||
| } |
There was a problem hiding this comment.
I configured this so that tproxy is a toggle (🤷). If tproxy is enabled, we do not need to include an explicit upstream. If tproxy is not enabled, then include the explicit upstream.
I'll defer to others on how we want to structure these.
pglass
force-pushed
the
pglass/NET-3685/pmtls-integration-test
branch
from
ef46c4f to
4f1373f
Compare
huikang
approved these changes
Apr 24, 2023
pglass
commented
Apr 24, 2023
| func assertHTTPRequestToVirtualAddress(t *testing.T, clientService libservice.Service) { | ||
| timer := &retry.Timer{Timeout: 120 * time.Second, Wait: 500 * time.Millisecond} | ||
|
|
||
| retry.RunWith(timer, t, func(r *retry.R) { |
There was a problem hiding this comment.
Added a retry loop for this check and moved into a function.
pglass
commented
Apr 24, 2023
| t.Logf("making call to upstream\nerr = %v\nout = %s", err, out) | ||
| require.NoError(r, err) | ||
| require.Regexp(r, `Virtual IP: 240.0.0.\d+`, out) | ||
| require.Contains(r, out, "FORTIO_NAME=static-server") |
There was a problem hiding this comment.
Updated this to validate the response is from the upstream static-server (similar to libassert.AssertFortioName)
pglass
force-pushed
the
pglass/NET-3685/pmtls-integration-test
branch
from
ef38f71 to
5334082
Compare
added 2 commits
April 25, 2023 12:07
Previously, when test splitting allocated multiple test directories to a runner, the workflow ran `go tests "./test/dir1 ./test/dir2"` which results in a directory not found error. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a basic integration test for TProxy:
consul connect redirect-trafficcommand to apply iptables rulesThis took some fiddling to setup, so there are some workarounds for the moment:
Testing & Reproduction steps
PR Checklist