Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Follow-up fixes to consul connect envoy command into release/1.15.x #16542

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16530 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

While trying to demo #15794, I discovered some minor issues with the UX when displaying logs to a user:

  • I had been checking for TLS and Plaintext ports to be < 0 (src), assuming that 0 meant a user had not set the port and it would be default. It turns out that 0 actually means gRPC is disabled and we will not get back the -1 values a user might pass as consul config.
  • There is an Info log which prints to stdout, which is undesirable because -bootstrap expects the text which gets printed to stdout to be well-formatted JSON

Testing & Reproduction steps

No logical changes; mockAgent in the test has been updated to behave closer to the real agent

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/kisunji/NET-3011-consul-connect-envoy-v2/really-sharp-jackass branch from 48b0875 to aab2e22 Compare March 6, 2023 15:32
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/kisunji/NET-3011-consul-connect-envoy-v2/really-sharp-jackass branch from 9078a0d to 3c5a460 Compare March 6, 2023 15:32
@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Mar 6, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 494fba2 into release/1.15.x Mar 6, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/kisunji/NET-3011-consul-connect-envoy-v2/really-sharp-jackass branch March 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/cli Flags and documentation for the CLI interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants