Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Gateway Test HTTPPathRewrite into release/1.15.x #16466

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16418 to be assessed for backporting due to the inclusion of the label backport/1.15.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Depends on the work done here #16278, ports the additional test HTTPPathRewrite, plus adds some helper functions to run the test cases.

Testing & Reproduction steps

go test ./...

Links

Original gateway e2e test

PR Checklist

  • [X ] updated test coverage
  • external facing docs updated
  • [X ] not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/gateway-test-http-route-path-rewrite/socially-tolerant-egret branch 2 times, most recently from 2606565 to e91cc8f Compare February 28, 2023 20:16
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 28, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • sarahalsmiller
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@sarahalsmiller sarahalsmiller marked this pull request as ready for review February 28, 2023 22:06
@sarahalsmiller sarahalsmiller enabled auto-merge (squash) February 28, 2023 22:15
@sarahalsmiller sarahalsmiller merged commit 10b5250 into release/1.15.x Feb 28, 2023
@sarahalsmiller sarahalsmiller deleted the backport/gateway-test-http-route-path-rewrite/socially-tolerant-egret branch February 28, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants