Backport of Add stricter validation and some normalization code for API Gateway ConfigEntries into release/1.15.x #16312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/api-gateway-stricter-validation/marginally-funky-starfish
branch
from
d2bd8d6
to
663bc25
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 17, 2023
|
Closed with manual backport in #16317 -- sorry about my sloppy merge commits that are freaking out the backport assistant. |
andrewstucki
deleted the
backport/api-gateway-stricter-validation/marginally-funky-starfish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16304 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
I added stricter validation on writes for our config entries and also added some better normalization code. While most of these errors are already handled by setting invalid statuses on the config entries at reconciliation, this surfaces configuration errors quicker and also makes our reliant xDS code a bit more robust (for example, we weren't re-checking the DNS hostnames in certificates for later SNI generation, which could make envoy blow up).
This is stacked on #16300.
PR Checklist
Overview of commits