Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration merging for implicit tproxy upstreams. #16000

Merged
merged 4 commits into from
Jan 18, 2023

Commits on Jan 18, 2023

  1. Fix configuration merging for implicit tproxy upstreams.

    Change the merging logic so that the wildcard upstream has correct proxy-defaults
    and service-defaults values combined into it. It did not previously merge all fields,
    and the wildcard upstream did not exist unless service-defaults existed (it ignored
    proxy-defaults, essentially).
    
    Change the way we fetch upstream configuration in the xDS layer so that it falls back
    to the wildcard when no matching upstream is found. This is what allows implicit peer
    upstreams to have the correct "merged" config.
    
    Change proxycfg to always watch local mesh gateway endpoints whenever a peer upstream
    is found. This simplifies the logic so that we do not have to inspect the "merged"
    configuration on peer upstreams to extract the mesh gateway mode.
    hashi-derek committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    fc4ce26 View commit details
    Browse the repository at this point in the history
  2. Add changelog.

    hashi-derek committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    4e24bc3 View commit details
    Browse the repository at this point in the history
  3. Fix flaky unit test.

    hashi-derek committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    ee59d4a View commit details
    Browse the repository at this point in the history
  4. Update changelog wording.

    hashi-derek committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    47eb461 View commit details
    Browse the repository at this point in the history