Fix TLS_BadVerify test assertions on macOS #15903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
added
pr/no-changelog
kisunji
reviewed
Jan 4, 2023
| r.Fatalf("should fail with certificate error %v", notif.OutputMap()) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| // isInvalidCertificateError checks the error string for an untrusted certificate error. | ||
| // The specific error message is different on Linux and macOS. |
There was a problem hiding this comment.
Can we add a "this is safe to remove when golang/go#52010 is addressed"
|
Cause: golang/go#52010 |
kisunji
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On macOS, we get a different error message for an untrusted TLS certificate which causes a couple of check tests cases to fail. This fixes the assertion so that these tests pass on macOS.
Testing & Reproduction steps
PR Checklist