Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PeerName to Peer on prepared queries and exported services #14854

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Rename PeerName to Peer on prepared queries and exported services #14854

merged 1 commit into from
Oct 4, 2022

Conversation

erichaberkorn
Copy link
Contributor

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified labels Oct 4, 2022
@erichaberkorn erichaberkorn force-pushed the rename-peer-name-to-peer branch 2 times, most recently from 0c51cf8 to f1d219b Compare October 4, 2022 14:35
@erichaberkorn erichaberkorn force-pushed the rename-peer-name-to-peer branch 3 times, most recently from 9a94916 to 9b5da1b Compare October 4, 2022 14:48
@erichaberkorn erichaberkorn force-pushed the rename-peer-name-to-peer branch from 9b5da1b to 614ebeb Compare October 4, 2022 14:56
@erichaberkorn erichaberkorn marked this pull request as ready for review October 4, 2022 16:55
@erichaberkorn erichaberkorn requested a review from a team as a code owner October 4, 2022 16:55
@erichaberkorn erichaberkorn requested a review from a team October 4, 2022 16:56
trujillo-adam
trujillo-adam approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the docs side

@erichaberkorn erichaberkorn merged commit 1b56544 into main Oct 4, 2022
@erichaberkorn erichaberkorn deleted the rename-peer-name-to-peer branch October 4, 2022 18:46
@nathancoleman nathancoleman mentioned this pull request Nov 7, 2022
Closed
3 tasks
@DanStough DanStough mentioned this pull request Nov 21, 2022
Closed
@DanStough DanStough mentioned this pull request Nov 30, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashi-derek hashi-derek hashi-derek approved these changes

@trujillo-adam trujillo-adam trujillo-adam approved these changes

Assignees
No one assigned
Labels
theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erichaberkorn @trujillo-adam @hashi-derek