Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include stream-related information in peering endpoints #14747

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Include stream-related information in peering endpoints #14747

merged 4 commits into from
Oct 10, 2022

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Sep 23, 2022 •
edited by freddygv
Loading

Description

This PR adds a new StreamStatus object within Peerings which contains information about the health of the peering:

  • Imported service list
  • Exported service list
  • Last timestamp a heartbeat message was received from the peer
  • Last timestamp we received a message from the peer
  • Last timestamp we sent a message to the peer

Testing & Reproduction steps

  • Unit tests
  • Manual testing

@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface labels Sep 23, 2022
@kisunji kisunji force-pushed the kisunji/NET-801-add-peer-stream-status branch from 186e907 to f956e96 Compare September 23, 2022 22:22
kisunji
kisunji commented Sep 23, 2022
View reviewed changes
agent/consul/state/peering.go
// We may need to avoid clobbering existing values.
req.Peering.ImportedServiceCount = existing.ImportedServiceCount
req.Peering.ExportedServiceCount = existing.ExportedServiceCount
req.Peering.StreamStatus = nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid confusion by never writing StreamStatus to the state store

@erichaberkorn erichaberkorn force-pushed the kisunji/NET-801-add-peer-stream-status branch from 3300c0a to 9c42b78 Compare October 7, 2022 17:54
@freddygv freddygv force-pushed the kisunji/NET-801-add-peer-stream-status branch from ef55841 to bf72df7 Compare October 10, 2022 19:20
@freddygv freddygv marked this pull request as ready for review October 10, 2022 19:29
@freddygv freddygv merged commit a73c6a2 into main Oct 10, 2022
@freddygv freddygv deleted the kisunji/NET-801-add-peer-stream-status branch October 10, 2022 20:07
@freddygv freddygv mentioned this pull request Oct 10, 2022
Closed
3 tasks
@tauhid621 tauhid621 mentioned this pull request Dec 13, 2023
Merged
4 tasks
This was referenced Dec 14, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

Assignees
No one assigned
Labels
theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kisunji @freddygv