ui: Move peers to a subapplication #13725
Conversation
johncowen
added
theme/ui
github-actions
bot
added
the
type/ci
johncowen
removed
the
type/ci
| @@ -81,7 +81,7 @@ as |key value|}} | |||
| {{#each | |||
| (get | |||
| (require '/models/peer' | |||
| path='schema' | |||
There was a problem hiding this comment.
Oh forgot to mention, this missed a PR somehow for the filtering thing, I was gonna PR it separate, but it slipped in here in the copy over, I'm happy to leave it in here, but let me know if you want me to PR separate.
| @@ -12,7 +12,7 @@ Below is a list of the most commonly used functions as bookmarklets followed by | |||
| | [Enable ACLs](javascript:Scenario('CONSUL_ACLS_ENABLE=1')) | Enable ACLs | | |||
| | [Enable TProxy](javascript:Scenario('CONSUL_TPROXY_ENABLE=1')) | Enable TProxy | | |||
| | [Enable Nspaces](javascript:Scenario('CONSUL_NSPACES_ENABLE=1')) | Enable Namespace Support | | |||
| | [Enable Peers](javascript:Scenario('CONSUL_PEERING_ENABLE=1')) | Enable Peers Support | | |||
| | [Enable Peers](javascript:Scenario('CONSUL_PEERINGS_ENABLE=1')) | Enable Peering Support | | |||
There was a problem hiding this comment.
do we need to update get-environment as well? I think this is where this cookie value is being read. And we are changing from CONSUL_PEERING_ENABLE to CONSUL_PEERINGS_ENABLE here.
There was a problem hiding this comment.
i think I did it everywhere, let me check again just incase
There was a problem hiding this comment.
I missed a couple 😬 I've added those and searched the codebase for references to that to triple check, thanks for the nudge!
johncowen
force-pushed
the
ui/chore/move-peers-subapp
branch
from
4b7c2b8 to
1c47c97
Compare
|
a rebase has made some test weirdness here, just giving it all a once over before merge |
Description
This PR moves the peering feature into a sub-application to take advantage of the extra features that offers.
Note there is a little more moving around/renaming to be done here going by the fact that we have decided to use the term
Peeringmore over justPeerfor code things.All discussed offline.
PR Checklist
/cc @LevelbossMike