Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add annotations for consul-sidecar resource overrides #12142

Merged
merged 1 commit into from
Jan 27, 2022
Merged

docs: Add annotations for consul-sidecar resource overrides #12142

merged 1 commit into from
Jan 27, 2022

Conversation

ishustava
Copy link
Contributor

@ishustava ishustava commented Jan 20, 2022 •
edited
Loading

Add docs for hashicorp/consul-k8s#956

Note: this will need to be merged together or after the next consul-k8s release

@ishustava ishustava requested a review from a team as a code owner January 20, 2022 19:15
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jan 20, 2022
@ishustava ishustava requested review from ndhanushkodi, a team and thisisnotashwin and removed request for a team January 20, 2022 19:15
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

david-yu
david-yu approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thisisnotashwin
thisisnotashwin approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@ishustava ishustava added the pr/no-changelog PR does not need a corresponding .changelog entry label Jan 20, 2022
@ishustava ishustava merged commit ea37574 into main Jan 27, 2022
@ishustava ishustava deleted the ishustava/update-consul-sidecar-resources-anno branch January 27, 2022 21:25
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/569052.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit ea37574 onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 27, 2022
@ishustava @hc-github-team-consul-core
docs: Add annotations for consul-sidecar resource overrides (#12142)
0922c7f
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit ea37574 onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 27, 2022
@ishustava @hc-github-team-consul-core
docs: Add annotations for consul-sidecar resource overrides (#12142)
5fc0909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@david-yu david-yu david-yu approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ishustava @hashicorp-ci @hc-github-team-consul-core @david-yu @thisisnotashwin