Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated the description of min_quorum #12014

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

neenap
Copy link
Contributor

@neenap neenap commented Jan 10, 2022

Added in clarification on how autopilot uses min_quorum

@neenap neenap requested a review from a team January 10, 2022 23:40
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 10, 2022

CLA assistant check
All committers have signed the CLA.

@neenap neenap self-assigned this Jan 10, 2022
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jan 10, 2022
@karl-cardenas-coding karl-cardenas-coding added the event/consul-docs-day A day focused on improving Consul's documentation. Date: Jan 10, 2022. label Jan 10, 2022
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@@ -919,7 +919,7 @@ Valid time units are 'ns', 'us' (or 'µs'), 'ms', 's', 'm', 'h'."
unhealthy. Defaults to 250.

- `min_quorum` - Sets the minimum number of servers necessary
in a cluster before autopilot can prune dead servers. There is no default.
in a cluster. Autopilot will stop pruning dead servers when this minimum is reached. There is no default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM;

As I was parsing thru @banks's comment here, I was thinking if we could encourage practitioners to set a reasonable default, given N := number of servers

@blake blake added the pr/no-changelog PR does not need a corresponding .changelog entry label Jan 11, 2022
@karl-cardenas-coding karl-cardenas-coding merged commit 209d03c into main Jan 12, 2022
@karl-cardenas-coding karl-cardenas-coding deleted the neenap-patch-1 branch January 12, 2022 14:55
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/550147.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 209d03c onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 12, 2022
docs: updated the description of min_quorum
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 209d03c onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 12, 2022
docs: updated the description of min_quorum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event/consul-docs-day A day focused on improving Consul's documentation. Date: Jan 10, 2022. pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants