Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document setting dashboard_url on k8s #10510

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jun 27, 2021

It's tricky because the {{ needs to be escaped with Helm.

Fixes hashicorp/consul-helm#1006

It's tricky because the `{{` needs to be escaped with Helm.
@lkysow lkysow added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick pr/no-changelog PR does not need a corresponding .changelog entry labels Jun 27, 2021
@lkysow lkysow requested a review from ndhanushkodi June 27, 2021 17:34
@johncowen
Copy link
Contributor

Hey @lkysow 👋

I always wondered whether we should support JS style TemplateLiteral interpolation here so "${}":

http://myvirtualmachine:3000/d/4Z9CWegnz/test-consul?orgId=1&var-service=${Service.Name}&var-namespace=${Service.Namespace}&var-dc=${Datacenter}

Would that help us not get into a situation where escaping is needed, does ${} have any special meaning in helm-land?

@lkysow
Copy link
Member Author

lkysow commented Jun 29, 2021

Would that help us not get into a situation where escaping is needed, does ${} have any special meaning in helm-land?

Yes that would work. Helm uses go templating so that's why there's an issue since Consul's using that too.

@david-yu david-yu self-requested a review June 30, 2021 02:44
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkysow lkysow merged commit 68c4c23 into master Jun 30, 2021
@lkysow lkysow deleted the lkysow/ui-dashboard-docs branch June 30, 2021 16:16
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/401017.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 68c4c23 onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jun 30, 2021
It's tricky because the `{{` needs to be escaped with Helm.
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 68c4c23 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jun 30, 2021
It's tricky because the `{{` needs to be escaped with Helm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable Interpolation within Helm chart
4 participants