-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Document setting dashboard_url on k8s #10510
Conversation
It's tricky because the `{{` needs to be escaped with Helm.
Hey @lkysow 👋 I always wondered whether we should support JS style TemplateLiteral interpolation here so
Would that help us not get into a situation where escaping is needed, does |
Yes that would work. Helm uses go templating so that's why there's an issue since Consul's using that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/401017. |
🍒✅ Cherry pick of commit 68c4c23 onto |
It's tricky because the `{{` needs to be escaped with Helm.
🍒✅ Cherry pick of commit 68c4c23 onto |
It's tricky because the `{{` needs to be escaped with Helm.
It's tricky because the
{{
needs to be escaped with Helm.Fixes hashicorp/consul-helm#1006