Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS resolver does not set NXDOMAIN code if all service instances are unhealthy #1142

Closed
armon opened this issue Jul 29, 2015 · 1 comment
Closed

DNS resolver does not set NXDOMAIN code if all service instances are unhealthy #1142

armon opened this issue Jul 29, 2015 · 1 comment
Labels
type/bug Feature does not function as expected

Comments

@armon
Copy link
Member

armon commented Jul 29, 2015

We check if there are no service instances in the DNS parser (https://github.com/hashicorp/consul/blob/master/command/agent/dns.go#L482) before we do the filtering on health (https://github.com/hashicorp/consul/blob/master/command/agent/dns.go#L499).

This means we properly set the response code to NXDOMAIN if there are no instances, but we respond with no answers with NOERROR if all the instances are being filtered out. This should also be NXDOMAIN to avoid confusing recursive resolvers.
@armon armon added the type/bug Feature does not function as expected label Jul 29, 2015
ryanbreen added a commit that referenced this issue Jul 29, 2015
@ryanbreen
Test for GH-1142.
0a7dc85
ryanbreen added a commit that referenced this issue Jul 29, 2015
@ryanbreen
Merge pull request #1143 from hashicorp/GH-1142
018fd69 
Check NXDOMAIN after filtering nodes
@ryanbreen
Copy link
Contributor

Fixed via GH-1143.

@ekmixon ekmixon mentioned this issue Nov 4, 2023
Open
@ekmixon ekmixon mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Feature does not function as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanbreen @armon