go-tests workflow

hashicorp · Mar 28, 2023 · df9d97f · df9d97f
1 parent 4b2137c
commit df9d97f
Show file tree

Hide file tree

Showing 8 changed files with 537 additions and 13 deletions.
diff --git a/.github/scripts/notify_slack.sh b/.github/scripts/notify_slack.sh
@@ -0,0 +1,27 @@
+#!/usr/bin/env bash
+
+set -uo pipefail
+
+# This script is used in GitHub Actions pipelines to notify Slack of a job failure.
+
+if [[ $GITHUB_REF_NAME == "main" ]]; then
+	GITHUB_ENDPOINT="https://github.com/${GITHUB_REPOSITORY}/commit/${GITHUB_SHA}"
+	GITHUB_ACTIONS_ENDPOINT="https://github.com/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}"
+	COMMIT_MESSAGE=$(git log -1 --pretty=%B | head -n1)
+	SHORT_REF=$(git rev-parse --short "${GITHUB_SHA}")
+	curl -X POST -H 'Content-type: application/json' \
+	--data \
+	"{ \
+	\"attachments\": [ \
+		{ \
+		\"fallback\": \"GitHub Actions workflow failed!\", \
+		\"text\": \"❌ Failed: \`${GITHUB_ACTOR}\`'s <${GITHUB_ACTIONS_ENDPOINT}|${GITHUB_JOB}> job failed for commit <${GITHUB_ENDPOINT}|${SHORT_REF}> on \`${GITHUB_REF_NAME}\`!\n\n- <${COMMIT_MESSAGE}\", \
+		\"footer\": \"${GITHUB_REPOSITORY}\", \
+		\"ts\": \"$(date +%s)\", \
+		\"color\": \"danger\" \
+		} \
+	] \
+	}" "${FEED_CONSUL_GH_URL}"
+else
+	echo "Not posting slack failure notifications for non-main branch"
+fi
diff --git a/.github/scripts/rerun_fails_report.sh b/.github/scripts/rerun_fails_report.sh
@@ -0,0 +1,24 @@
+#!/usr/bin/env bash
+# Copyright (c) HashiCorp, Inc.
+# SPDX-License-Identifier: MPL-2.0
+
+#
+# Add a comment on the github PR if there were any rerun tests.
+#
+set -eu -o pipefail
+
+report_filename="${1?report filename is required}"
+if [ ! -s "$report_filename" ]; then
+    echo "gotestsum rerun report file is empty or missing"
+    exit 0
+fi
+
+function report {
+    echo ":repeat: gotestsum re-ran some tests in https://github.com/hashicorp/consul/commit/$GITHUB_SHA/checks"
+    echo
+    echo '```'
+    cat "$report_filename"
+    echo '```'
+}
+
+report
diff --git a/.github/workflows/build-distros.yml b/.github/workflows/build-distros.yml
@@ -9,19 +9,7 @@ permissions:
 
 jobs:
   check-go-mod:
-    runs-on: ubuntu-22.04
-    steps:
-    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected]
-    - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # [email protected]
-      with:
-        go-version-file: 'go.mod'
-    - run: go mod tidy
-    - run: |
-        if [[ -n $(git status -s) ]]; then
-          echo "Git directory has changes"
-          git status -s
-          exit 1
-        fi
+    uses: ./.github/workflows/reusable-check-go-mod.yml
 
   build-386:
     needs: check-go-mod

diff --git a/.github/workflows/go-tests.yml b/.github/workflows/go-tests.yml
@@ -0,0 +1,276 @@
+name: go-tests
+
+on: 
+  push:
+    branches-ignore:
+      - stable-website
+      - 'docs/**'
+      - 'ui/**'
+      - 'mktg-**' # Digital Team Terraform-generated branches' prefix
+      - 'backport/docs/**'
+      - 'backport/ui/**'
+      - 'backport/mktg-**'
+
+permissions:
+  contents: read
+
+env:
+  TEST_RESULTS: /tmp/test-results
+  GOTESTSUM_VERSION: 1.8.2
+
+jobs:
+  setup:
+    name: Setup
+    runs-on: ubuntu-latest
+    outputs:
+      compute-small: ${{ steps.setup-outputs.outputs.compute-small }}
+      compute-medium: ${{ steps.setup-outputs.outputs.compute-medium }}
+      compute-large: ${{ steps.setup-outputs.outputs.compute-medium }}
+      compute-xl: ${{ steps.setup-outputs.outputs.compute-xl }}
+    steps:
+    - id: setup-outputs
+      name: Setup outputs
+      run: |
+          echo 'compute-small=["custom", "linux", "small"]' >> $GITHUB_OUTPUT
+          echo 'compute-medium=["custom", "linux", "medium"]' >> $GITHUB_OUTPUT
+          echo 'compute-large=["custom", "linux", "large"]' >> $GITHUB_OUTPUT
+          echo 'compute-xl=["custom", "linux", "xl"]' >> $GITHUB_OUTPUT
+
+  check-go-mod:
+    needs: 
+    - setup
+    uses: ./.github/workflows/reusable-check-go-mod.yml
+  check-generated-protobuf:
+    needs: 
+    - setup   
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected]
+    - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # [email protected]
+      with:
+        go-version-file: 'go.mod'
+    - run: make proto-tools
+      name: Install protobuf
+    - run: make proto-format
+      name: "Protobuf Format"
+    - run: make --always-make proto
+    - run: |
+            if ! git diff --exit-code; then
+              echo "Generated code was not updated correctly"
+              exit 1
+            fi
+    - run: make proto-lint
+      name: "Protobuf Lint"
+    - name: Notify Slack
+      if: failure()
+      run: .github/scripts/notify_slack.sh 
+  check-generated-deep-copy:
+    needs: 
+    - setup   
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected]
+    - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # [email protected]
+      with:
+        go-version-file: 'go.mod'
+    - run: make codegen-tools
+      name: Install deep-copy
+    - run: make --always-make deep-copy
+    - run: |
+        if ! git diff --exit-code; then
+          echo "Generated code was not updated correctly"
+          exit 1
+        fi
+    - name: Notify Slack
+      if: failure()
+      run: .github/scripts/notify_slack.sh  
+  lint-enums:
+    needs: 
+    - setup   
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected]
+    - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # [email protected]
+      with:
+        go-version-file: 'go.mod'
+    - run: go install github.com/reillywatson/enumcover/cmd/enumcover@master && enumcover ./...   
+    - name: Notify Slack
+      if: failure()
+      run: .github/scripts/notify_slack.sh
+
+  lint-container-test-deps:
+    needs: 
+    - setup   
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected]
+    - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # [email protected]
+      with:
+        go-version-file: 'go.mod'
+    - run: make lint-container-test-deps 
+    - name: Notify Slack
+      if: failure()
+      run: .github/scripts/notify_slack.sh
+
+  lint-consul-retry:
+    needs: 
+    - setup   
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected]
+    - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # [email protected]
+      with:
+        go-version-file: 'go.mod'
+    - run: go install github.com/hashicorp/lint-consul-retry@master && lint-consul-retry
+    - name: Notify Slack
+      if: failure()
+      run: .github/scripts/notify_slack.sh
+
+  lint:
+    needs: 
+    - setup   
+    uses: ./.github/workflows/reusable-lint.yml
+
+  lint-32bit:
+    needs: 
+    - setup   
+    uses: ./.github/workflows/reusable-lint.yml
+    with:
+      go-arch: "386"
+
+  # create a development build
+  dev-build:
+    needs: 
+    - setup   
+    uses: ./.github/workflows/reusable-dev-build.yml
+
+  # create a development build for arm64
+  dev-build-arm64:
+    needs: 
+    - setup   
+    uses: ./.github/workflows/reusable-dev-build.yml
+    with:
+      uploaded-binary-name: 'consul-bin-arm64'
+      # runs-on: ${{ needs.setup.outputs.compute-arm64 }}
+
+  go-test-arm64:
+    # TODO(JM):  Fix to run on arm64
+    needs: 
+    - setup   
+    - dev-build-arm64
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: .
+      go-version: "1.20"
+      uploaded-binary-name: 'consul-bin-arm64'
+      # runs-on: ${{ needs.setup.outputs.compute-arm64 }}
+    # steps:
+    #   - name: make dev
+    #     run: |
+    #       # TODO(JM)- figure out why this is only needed on these branches
+    #       # if [[ '${{ github.ref }}' == 'refs/heads/main' || startsWith('${{ github.ref }}', 'refs/heads/release/') ]]; then
+    #         make dev
+    #       # fi
+    #   # TODO(JM)- if not always building above, re-enable this.
+    #   # - uses: actions/download-artifact@v3
+    #   #   with:
+    #   #     name: consul-bin
+    #   #     path: ./bin/consul
+
+  go-test:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: .
+      go-version: "1.20"
+    # steps:
+    # TODO(JM) confirm where this comes from 
+    # and whether it is ok to not get it from an image
+    #   - run:  mkdir -p ${{env.TEST_RESULTS}}
+    #   # - name: Download consul
+    #   #   run: |
+    #   #     mkdir -p $HOME/bin
+    #   #     container_id=$(docker create ${{env.CONSUL_OSS_DOCKER_IMAGE}})
+    #   #     docker cp "$container_id:/bin/consul" $HOME/bin/consul
+    #   #     docker rm "$container_id"
+
+  go-test-race:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: .
+      go-version: "1.20"
+      args: "-race -gcflags=all=-d=checkptr=0"
+
+  go-test-32bit:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: .
+      go-version: "1.20"
+      go-arch: "386"
+
+  go-test-envoyextensions:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: envoyextensions
+      go-version: "1.20"
+
+  go-test-troubleshoot:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: troubleshoot
+      go-version: "1.20"
+
+  go-test-api-1-19:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: api
+      go-version: "1.19"
+
+  go-test-api-1-20:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: api
+      go-version: "1.20"
+
+  go-test-sdk-1-19:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: sdk
+      go-version: "1.19"
+
+  go-test-sdk-1-20:
+    needs: 
+    - setup   
+    - dev-build
+    uses: ./.github/workflows/reusable-unit.yml
+    with:
+      directory: sdk
+      go-version: "1.20"
+
+  noop:
+    runs-on: ubuntu-latest
+    steps:
+      - run: "echo ok"
diff --git a/.github/workflows/reusable-check-go-mod.yml b/.github/workflows/reusable-check-go-mod.yml
@@ -0,0 +1,24 @@
+name: check-go-mod
+
+on:
+  workflow_call:
+
+jobs:
+  check-go-mod:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected]
+    - uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # [email protected]
+      with:
+        go-version-file: 'go.mod'
+    - run: go mod tidy
+    - run: |
+        if [[ -n $(git status -s) ]]; then
+          echo "Git directory has changes"
+          git status -s
+          exit 1
+        fi
+    - name: Notify Slack
+      if: failure()
+      run: .github/scripts/notify_slack.sh