Skip to content

Commit

Permalink
Revert "feat: add alert to link to hcp modal to ask a user refresh a …
Browse files Browse the repository at this point in the history
…page; up… (#20682)"

This reverts commit dd833d9.
  • Loading branch information
chris-hut committed Mar 11, 2024
1 parent 08bfca0 commit 6168199
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
|G|>
<G.Legend>Select cluster access mode before linking</G.Legend>
<G.HelperText>Control the level of access that HCP Consul Central has to your linked cluster.
<Hds::Link::Inline @href="https://developer.hashicorp.com/hcp/docs/consul/concepts/cluster-permissions" @isHrefExternal={{true}}
<Hds::Link::Inline @href="https://developer.hashicorp.com/consul/docs/security/acl" @isHrefExternal={{true}}
@color="secondary">Learn more
</Hds::Link::Inline>
</G.HelperText>
Expand Down Expand Up @@ -89,9 +89,6 @@
{{/if}}
</div>
{{/if}}
<Hds::Alert class="link-to-hcp-modal__refresh-page-alert" @type="compact" data-test-link-to-hcp-modal-refresh-page-alert as |A|>
<A.Description>After you link your cluster to HCP, close this modal and refresh the page.</A.Description>
</Hds::Alert>
</M.Body>
<M.Footer as |F|>
<Hds::ButtonSet>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
&__no-acls-alert {
margin-bottom: 16px;
}
&__refresh-page-alert {
margin-top: 16px;
margin-bottom: 8px;
}
&__generate-token {
display: flex;
flex-direction: column;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { BlockingEventSource as RealEventSource } from 'consul-ui/utils/dom/even
import { ACCESS_LEVEL } from 'consul-ui/components/link-to-hcp-modal';

const modalSelector = '[data-test-link-to-hcp-modal]';
const modalRefreshPageAlertSelector = '[data-test-link-to-hcp-modal-refresh-page-alert]';
const modalNoACLsAlertSelector = '[data-test-link-to-hcp-modal-no-acls-alert]';
const modalOptionReadOnlySelector = '#accessMode-readonly';
const modalOptionReadOnlyErrorSelector = '[data-test-link-to-hcp-modal-access-level-options-error]';
Expand Down Expand Up @@ -89,7 +88,6 @@ module('Integration | Component | link-to-hcp-modal', function (hooks) {

assert.dom(modalSelector).exists({ count: 1 });
assert.dom(`${modalSelector} ${modalNoACLsAlertSelector}`).doesNotExist();
assert.dom(`${modalSelector} ${modalRefreshPageAlertSelector}`).isVisible();

// select read-only
await click(`${modalSelector} ${modalOptionReadOnlySelector}`);
Expand Down Expand Up @@ -188,8 +186,6 @@ module('Integration | Component | link-to-hcp-modal', function (hooks) {

assert.dom(modalSelector).exists({ count: 1 });
assert.dom(`${modalSelector} ${modalNoACLsAlertSelector}`).doesNotExist();
assert.dom(`${modalSelector} ${modalRefreshPageAlertSelector}`).isVisible();

// select read-only
await click(`${modalSelector} ${modalOptionReadOnlySelector}`);

Expand Down Expand Up @@ -217,8 +213,6 @@ module('Integration | Component | link-to-hcp-modal', function (hooks) {

assert.dom(modalSelector).exists({ count: 1 });
assert.dom(`${modalSelector} ${modalNoACLsAlertSelector}`).isVisible();
assert.dom(`${modalSelector} ${modalRefreshPageAlertSelector}`).isVisible();

// select read-only
await click(`${modalSelector} ${modalOptionReadOnlySelector}`);

Expand Down

0 comments on commit 6168199

Please sign in to comment.