Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of the word "sane" #1731

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Replace uses of the word "sane" #1731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f823979
sane -> reasonable
angrycub Mar 28, 2023
afbe848
Apply suggestions from code review
angrycub Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ BUG FIXES:

BREAKING CHANGES:

* Retry now has a sane maximum default. Previous versions of Consul Template
* Retry now has a reasonable maximum default. Previous versions of Consul Template
angrycub marked this conversation as resolved.
Show resolved Hide resolved
angrycub marked this conversation as resolved.
Show resolved Hide resolved
would retry indefinitely, potentially allowing the time between retries to
reach days, months, or years due to the exponential nature. Users wishing
to use the old behavior should set `max_backoff = 0` in their
Expand Down
6 changes: 3 additions & 3 deletions manager/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ import (
)

const (
// saneViewLimit is the number of views that we consider "sane" before we
angrycub marked this conversation as resolved.
Show resolved Hide resolved
// reasonableViewLimit is the number of views that we consider reasonable before we
angrycub marked this conversation as resolved.
Show resolved Hide resolved
// warn the user that they might be DDoSing their Consul cluster.
saneViewLimit = 128
reasonableViewLimit = 128
angrycub marked this conversation as resolved.
Show resolved Hide resolved
)

// Runner responsible rendering Templates and invoking Commands.
Expand Down Expand Up @@ -276,7 +276,7 @@ func (r *Runner) Start() {

for {
// Warn the user if they are watching too many dependencies.
if r.watcher.Size() > saneViewLimit {
if r.watcher.Size() > reasonableViewLimit {
angrycub marked this conversation as resolved.
Show resolved Hide resolved
log.Printf("[WARN] (runner) watching %d dependencies - watching this "+
"many dependencies could DDoS your servers", r.watcher.Size())
} else {
Expand Down