Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config default tweaks based on cts research #1697

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Jan 6, 2023

See this ticket for some details...
hashicorp/consul-terraform-sync#164

Summary: http.MaxIdleConnsPerHost was default to a very low value that caused TCP connections to not be reused across dependency monitoring. Only ~1 connections were being reused from the initial set of hcat requests to Consul, and the remaining dependencies required establishing a new connection.

Fixes #1603

See this ticket for some details...
hashicorp/consul-terraform-sync#164

Summary: http.MaxIdleConnsPerHost was default to a very low value that
caused TCP connections to not be reused across dependency monitoring.
Only ~1 connections were being reused from the initial set of hcat
requests to Consul, and the remaining dependencies required establishing
a new connection.
@eikenb eikenb added this to the v0.30.0 milestone Jan 6, 2023
@eikenb eikenb requested a review from a team January 6, 2023 22:25
@eikenb eikenb merged commit c6a80b6 into main Jan 6, 2023
@eikenb eikenb deleted the issue-1603-default-tweaks branch January 6, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider these changes to the default settings
1 participant