Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to resolve GH 17166 where agent crashes when no certs available #1639

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Attempt to resolve GH 17166 where agent crashes when no certs available #1639

merged 3 commits into from
Sep 16, 2022

Conversation

peteski22
Copy link

No description provided.

@eikenb eikenb added bug hashicat-update-required Changes that need to be ported to hashicat vault Related to the Vault integration labels Sep 16, 2022
@peteski22 peteski22 marked this pull request as ready for review September 16, 2022 20:20
@peteski22 peteski22 requested a review from a team September 16, 2022 20:20
eikenb
eikenb approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the fix make sense. This fixes the issue without introducing a new error condition that might have unintended side effects. 👍

@eikenb eikenb merged commit e5ddc02 into hashicorp:main Sep 16, 2022
@mpalmi mpalmi mentioned this pull request Sep 19, 2022
Closed
@peteski22 peteski22 deleted the 17166-fix-nil-cert-panic branch September 21, 2022 12:41
@eikenb eikenb modified the milestones: v0.30.0, v0.29.3 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikenb eikenb eikenb approved these changes

Assignees
No one assigned
Labels
bug hashicat-update-required Changes that need to be ported to hashicat vault Related to the Vault integration
Projects
None yet
Milestone
v0.29.3
Development

Successfully merging this pull request may close these issues.
2 participants
@peteski22 @eikenb