-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add map merge functionality #1500
add map merge functionality #1500
Conversation
@eikenb, I was wondering if I could get a review. We're looking to move pretty quick with this new functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shovelwagon, thanks for the PR! @eikenb is currently unavailable but will be around to review next week. I left a couple comments for minor nits that I noticed from an initial look but will leave it up to @eikenb!
Co-authored-by: lornasong <[email protected]>
Co-authored-by: lornasong <[email protected]>
@lornasong, thanks for the initial review! |
@eikenb, just wondering if there's anything you need from me? We're looking to get consul-template in our build pipeline within the next week and ideally we're not running on the fork. |
Hey @shovelwagon, I was going to wait until after I got 0.27 out to look at this but as it is a template function, so self contained, I'll take a look at it tomorrow while I'm waiting on some feedback on another PR (for 0.27). |
Thanks @eikenb! |
Proposed code for enhancement in #1499.