new docker image build setup #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to use new standard of downloading application from official release sources, including cryptographic verification. Cleans up entrypoint and makes separate init process optional. Standardizing on a minimal Alpine Linux based image. Note dumb-init was removed as it is not required to for consul-template, as it handles all the signaling properly, and docker has it built in so if a user wants it they can add it by running with `--init`. Shouldn't normally be necessary but might be useful if you have ill-behaved template commands.
|
See #1481 for some context. |
findkim
approved these changes
Jun 16, 2021
Comment on lines
+36
to
+37
| COPY fetch-n-verify.sh docker-entrypoint.sh / | ||
| RUN /fetch-n-verify.sh # removes self when done |
There was a problem hiding this comment.
I like this new approach to download the official released binary instead of building from source. Separates the dockerfile from the release process and the bulkiness of building from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use new standard of downloading application from official release sources, including cryptographic verification.
Cleans up entrypoint and makes separate init process optional. Standardizing on a minimal Alpine Linux based image.
Note dumb-init was removed as it is not required to for consul-template, as it handles all the signaling properly, and docker has it built in so if a user wants it they can add it by running with
--init. Shouldn't normally be necessary but might be useful if you have ill-behaved template commands.