Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unescaped json output #1432

Merged
merged 3 commits into from
Apr 24, 2021
Merged

Allow unescaped json output #1432

merged 3 commits into from
Apr 24, 2021

Conversation

nagypeterjob
Copy link
Contributor

#1430

Added toUnescapedJSON and toUnescapedJSONPretty functions (and tests) to be able to generate JSON without HTML escaping the resulting string. See Issue for more details.

I have also updated README.

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nagypeterjob nagypeterjob changed the title Allow unsecaped json Allow unescaped json output Dec 12, 2020
@nagypeterjob nagypeterjob mentioned this pull request Dec 13, 2020
Closed
@eikenb eikenb requested review from a team and removed request for a team January 5, 2021 21:06
eikenb
eikenb approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Going to delay merging it just slightly as I'll need to update the documentation refactor branch when I do and I can't do that right this moment.

@nagypeterjob
Copy link
Contributor Author

Thanks in advance @eikenb

eikenb
eikenb reviewed Apr 23, 2021
View reviewed changes
README.md Show resolved Hide resolved
@eikenb eikenb added hashicat-update-required Changes that need to be ported to hashicat waiting-reply and removed waiting-reply labels Apr 23, 2021
@eikenb eikenb merged commit fe2520f into hashicorp:master Apr 24, 2021
@eikenb eikenb added this to the 0.26.0 milestone Apr 27, 2021
@eikenb eikenb added the hashicat-update-complete Completed porting changes to hashicat label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikenb eikenb eikenb approved these changes

Assignees
No one assigned
Labels
enhancement hashicat-update-complete Completed porting changes to hashicat hashicat-update-required Changes that need to be ported to hashicat
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nagypeterjob @hashicorp-cla @eikenb