Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external FuncMaps #1425

Closed
wants to merge 1 commit into from

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Nov 6, 2020

Since Nomad uses CT as its underlying template engine, it would be nice to be able to pass functions from Nomad itself into the template configurations that it generates. I thought exposing a route to inject functions for applications that use CT internally might be a good middle ground to prevent even more template application sprawl.

This would allow Nomad to inject purpose-built templating functions into the rendering pipeline without having to make additional changes to consul-template.

Custom Functions could also be used to simplify the FunctionBlockList by allowing someone to implement their own no-op function to opaque an implementation provided in CT.

This could let us resolve #1312 and #1406 by allowing them to be passed into CT from Nomad using this scheme.

@eikenb
Copy link
Contributor

eikenb commented Nov 6, 2020

Hey @angrycub,

We're already working on this feature as part of hashicat, the in-progress library which replaces consul-template (as a library). It's progress was paused for a bit due to CTS deadlines around hashiconf, but I'm working on it again now.

@eikenb
Copy link
Contributor

eikenb commented Apr 23, 2021

We finally have CTS done enough that I've been fully freed up to get back to work on other projects and am reviewing these PRs again. I'd like to just reject/close this one, looking to moving Nomad hashicat for the feature.

@angrycub, is that OK?

@angrycub
Copy link
Contributor Author

Sure. No reason to keep this one.

@angrycub angrycub closed this Apr 23, 2021
@angrycub angrycub deleted the f-allow-external-funcs branch April 29, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants