Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer to log date / time in conistent format like in other places. #1412

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

aphorise
Copy link
Contributor

@aphorise aphorise commented Sep 2, 2020

Related to: Vault 9816 - where dates do not appear in an inconsistent manner.

@eikenb
Copy link
Contributor

eikenb commented Oct 1, 2020

Hey @aphorise, thanks for the PR and sorry for the delayed feedback.

It appears this is attempted to match consul-template's log output format to Vaults. This is indirectly in our plans, as we plan to switch to go-hclog when we have a chance (vault uses it's default format), but this I think helps in the mean time. Thanks.

@eikenb eikenb merged commit 15e145a into hashicorp:master Oct 1, 2020
@eikenb eikenb added this to the 0.25.1 milestone Oct 1, 2020
@calvn
Copy link
Contributor

calvn commented Oct 26, 2020

@eikenb should this be tagged for 0.25.2/0.26.0? 0.25.1 seems to be an existing release from July

@eikenb eikenb modified the milestones: 0.25.1, 0.25.2 Oct 27, 2020
@eikenb
Copy link
Contributor

eikenb commented Oct 27, 2020

@calvn Thanks!

@mladlow
Copy link

mladlow commented Dec 11, 2020

@eikenb - I'm not sure of the release cadence for consul-template. Did 0.25.2 get released?

@eikenb
Copy link
Contributor

eikenb commented Dec 12, 2020

No @mladlow, I'm sorry it hasn't been released yet. The team got sidetracked kicking off a new project which distracted us from our other projects for a time. After the holiday break we will be freeing up some time for this and will get a release out at that time. Sorry for the delay and lack of attention here. We are aware and are working to get things back in order and just beg for patience.

Thanks

@mladlow
Copy link

mladlow commented Dec 12, 2020

No worries - just looking for clarity!

@aphorise aphorise deleted the syslog-time-format branch November 3, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants