Simplify log level environment variable usage #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey, any news about this PR? |
eikenb
reviewed
Apr 27, 2021
| @@ -525,8 +525,7 @@ func (c *Config) Finalize() { | |||
|
|
|||
| if c.LogLevel == nil { | |||
| c.LogLevel = stringFromEnv([]string{ | |||
| "CT_LOG", | |||
| "CONSUL_TEMPLATE_LOG", | |||
| "CONSUL_TEMPLATE_LOG_LEVEL", | |||
There was a problem hiding this comment.
How about we just make it all 3. I really don't like breaking backwards compatibility unless absolutely necessary, but I think the new one is better. Thanks.
There was a problem hiding this comment.
Yes agree with you. I will do it this week.
There was a problem hiding this comment.
@eikenb As expected, just adding the new env variable
Adapt config_test accordingly and update documentation
sterchelen
force-pushed
the
log-level-usage
branch
from
a190ac8 to
a37e74f
Compare
sterchelen
requested review from
a team and
eikenb
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1328