Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user non-numeric to satisfy PSP #1332

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Make user non-numeric to satisfy PSP #1332

merged 1 commit into from
Jan 15, 2020

Conversation

funkypenguin
Copy link
Contributor

Hey guys,

I appreciate that the container no longer runs as root, but instead runs as the consul-template user.

This PR introduces a small change to the Alpine Dockerfile, in that it uses numeric UID/GID values for the USER statement. This is required when using PodSecurityPolicies under Kubernetes, to assure the admission controller that the container will not run as root. (Setting a non-numeric value like USER consul-template:consul-template is insufficient, since the Dockerfile could simply have renamed the root account, I guess!)

Cheers!
D

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 10, 2020

CLA assistant check
All committers have signed the CLA.

@eikenb
Copy link
Contributor

eikenb commented Jan 10, 2020

Thanks @funkypenguin,

I'll try to get this merged and re-build the docker images next week. It doesn't really change anything, almost being just a cosmetic tweak, so I don't think I'll worry about doing a release just to update the docker image.

@eikenb eikenb merged commit c54d0ab into hashicorp:master Jan 15, 2020
@eikenb
Copy link
Contributor

eikenb commented Jan 16, 2020

@funkypenguin I merged this and pushed up a new docker image built with it in place.

@eikenb eikenb added this to the 0.24.1 milestone Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants