fix loop to work with different int types #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikenb
force-pushed
the
issue1143-loop-int64-type
branch
from
1907131
to
833c588
Compare
`loop` when passed a scrach or $variable that contained an int as the
function was typed to only take int64. This changes it more like the
other functions that takes a interface{} and type switches/converts it
using reflect. Made it handle integer strings while I was at it.
Fixes #1143
eikenb
force-pushed
the
issue1143-loop-int64-type
branch
from
833c588
to
94ded09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix loop to work with different int types