Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using Go11Modules #1232

Closed
wants to merge 1 commit into from
Closed

Switch to using Go11Modules #1232

wants to merge 1 commit into from

Conversation

prologic
Copy link

No description provided.

@greut
Copy link
Contributor

greut commented Jul 17, 2019

You'll probably need #1230 (see #1208). I tend to like having the vendors versioned as well via go mod vendor, go build -mod=vendor

@prologic
Copy link
Author

Is there really a point in committing the source code to dependencies today? go mod makes all this painless and trivial to manage dependencies without polluting your source tree IHMO.

@jefferai
Copy link
Member

Duplicate of #1208

@prologic prologic closed this Jul 17, 2019
@greut
Copy link
Contributor

greut commented Jul 18, 2019

@prologic Agreed, until something gets deleted by someone else. https://status.npmjs.org/incidents/41zfb8qpvrdj

@prologic
Copy link
Author

Yeah that's true and a good reason to choose to vendor. Can't say I've run into that problem too often; and I'd just fork at that point :) Pros/Cons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prologic @greut @jefferai