-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syslog doesn't work after upgrade to 0.27 #1523
Comments
Hey @drTr0jan, thanks for filing the bug and particularly for linking to the culprit. 🙇 I'll look into this and see what I can do this week. Might also see if I can bolster the tests a bit in that area to prevent this from happening again. |
Found it. The problem is that the logutil.Multiwriter() short circuits the output when one of the Writers used either returns an error (which I knew) OR when the output character count doesn't match the input byte slice (which I didn't know)... it was the latter causing issues. Specifically this line... consul-template/logging/logging.go Line 35 in a009fea
That returns the wrong byte count as it includes the timestamp (so it is always longer). Fixing... |
PR up (for internal review). |
@eikenb, it looks like a workable. Thx. |
1) Update to 0.27.2: * syslog bug fixed - hashicorp/consul-template#1523 2) RC-script refactor: * fixed keyword; * added consul_template_syslog_output_tag variable, making them consistent with the rest of the ports tree; * fixed codestyle. PR: 259711
Consul Template version
consul-template v0.27.1 (release)
Configuration
Debug output
Expected behavior
Messages should be send to syslog.
Actual behavior
Messages send only to stdout.
References
Behavior is broken after #1476.
The text was updated successfully, but these errors were encountered: