-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service tag regex should support '=' and ':' #1049
Comments
@gmr The issue is that tags are supposed to be used within DNS as well, and those chars are out of scope of allowed chars. IMHO Fabio might try switching to service.weights and service.Meta :-) |
I just saw it as a request that the team asked for implementation on. If the scope should increase beyond the issue or request, I'm totally cool with closing it. Was just trying to help close out an issue that was tagged as wanting a contribution. |
@gmr Well, I don't think this is a bad idea however, I just explain why it is like this :-) On my side in consul-templaterb, I did not implement such limitation on chars within the tags, so I definitely it is a good idea :-) |
Merged in #1149 that adds this functionality. |
Because many system (ex. fabio) use '=' in service tags, we should support them in consul-template.
https://github.com/hashicorp/consul-template/blob/master/dependency/dependency.go#L21
AS IS:
TO BE:
The text was updated successfully, but these errors were encountered: