Make sure vault integration works with PSPs #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
requested review from
a team,
kschoche and
thisisnotashwin
and removed request for
a team
thisisnotashwin
approved these changes
Jan 21, 2022
| @@ -18,6 +18,7 @@ spec: | |||
| # Allow core volume types. | |||
| volumes: | |||
| - 'secret' | |||
| - 'emptyDir' | |||
There was a problem hiding this comment.
GENIUS! pure unadulterated genius.
| @@ -10,6 +10,7 @@ IMPROVEMENTS: | |||
| * Allow customization of `terminationGracePeriodSeconds` on the ingress gateways. [[GH-947](https://github.com/hashicorp/consul-k8s/pull/947)] | |||
| * Support `ui.dashboardURLTemplates.service` value for setting [dashboard URL templates](https://www.consul.io/docs/agent/options#ui_config_dashboard_url_templates_service). [[GH-937](https://github.com/hashicorp/consul-k8s/pull/937)] | |||
| * Allow using dash-separated names for config entries when using `kubectl`. [[GH-965](https://github.com/hashicorp/consul-k8s/pull/965)] | |||
| * Support Pod Security Policies with Vault integration. [[GH-985](https://github.com/hashicorp/consul-k8s/pull/985)] | |||
geobeau
pushed a commit
to geobeau/consul-k8s
that referenced
this pull request
May 20, 2022
* Add support for recursor flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
acceptance tests: https://app.circleci.com/pipelines/github/hashicorp/consul-k8s/4015/workflows/87c78757-4c96-4641-a2f0-d535bbe567fc/jobs/36509
How I expect reviewers to test this PR:
👀
Checklist: