-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable injecting sidecar container via helm configuration. #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 🎉 I've added a couple of minor edits, but nothing blocking
charts/consul/values.yaml
Outdated
@@ -596,6 +596,19 @@ server: | |||
# @type: array<map> | |||
extraVolumes: [] | |||
|
|||
# A list of sidecar containers. | |||
# @type: array<string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an array of objects/maps
# @type: array<string> | |
# @type: array<map> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the @type
line needs to be the last in the comment. For example:
# Example:
#
# ```yaml
# imagePullSecrets:
# - name: pull-secret-name
# - name: pull-secret-name-2
# ```
# @type: array<map>
charts/consul/values.yaml
Outdated
@@ -925,6 +938,19 @@ client: | |||
# @type: array<map> | |||
extraVolumes: [] | |||
|
|||
# A list of sidecar containers. | |||
# @type: array<string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# @type: array<string> | |
# @type: array<map> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some small nits.
charts/consul/values.yaml
Outdated
@@ -596,6 +596,19 @@ server: | |||
# @type: array<map> | |||
extraVolumes: [] | |||
|
|||
# A list of sidecar containers. | |||
# @type: array<string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the @type
line needs to be the last in the comment. For example:
# Example:
#
# ```yaml
# imagePullSecrets:
# - name: pull-secret-name
# - name: pull-secret-name-2
# ```
# @type: array<map>
|
||
} | ||
|
||
@test "client/DaemonSet: no extra client containers added" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@test "client/DaemonSet: no extra client containers added" { | |
@test "client/DaemonSet: no extra containers added by default" { |
Co-authored-by: Iryna Shustava <[email protected]>
Co-authored-by: Iryna Shustava <[email protected]>
Co-authored-by: Luke Kysow <[email protected]>
Co-authored-by: Luke Kysow <[email protected]>
Co-authored-by: Luke Kysow <[email protected]>
Co-authored-by: Luke Kysow <[email protected]>
Changes proposed in this PR:
Enable injecting sidecar container via helm configuration.
Based off Vault implementation https://github.com/hashicorp/vault-helm/pull/87/files#
server.extraContainers
andclient.extraContainers
tovalues.yaml
client-daemonset.yaml
andserver-statefulset.yaml
to check for extraContainersHow I've tested this PR:
helm install -f config.yaml nicoleta charts/consul
Sample
config.yaml
file used:How I expect reviewers to test this PR:
Checklist: