Fix bug where upstream env vars not set #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where we weren't setting the upstream environment variables when the upstream annotation was set: * <NAME>_CONNECT_SERVICE_HOST * <NAME>_CONNECT_SERVICE_PORT Since we're modifying a slice's values during iteration we must access the element via reference using the index.
lkysow
requested review from
a team,
kschoche and
sadjamz
and removed request for
a team
kschoche
approved these changes
Jul 5, 2021
sadjamz
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where we weren't setting the upstream environment variables
when the upstream annotation was set:
<NAME>_CONNECT_SERVICE_HOST<NAME>_CONNECT_SERVICE_PORTSince we're modifying a slice's values during iteration we must access
the element via reference using the index.
Fixes #549
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: