Fail sync if consul delete returns an error #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In case consul fails while attempting to delete a config entry, for eg because it is in use, update the sync value to being failed. - Add Age column to CRD printer columns
thisisnotashwin
requested review from
lkysow,
a team and
ishustava
and removed request for
a team
kschoche
reviewed
Oct 23, 2020
| @@ -247,7 +248,7 @@ type ServiceResolverFailover struct { | |||
| ServiceSubset string `json:"serviceSubset,omitempty"` | |||
| // Namespace is the namespace to resolve the requested service from to form | |||
| // the failover group of instances. If empty the current namespace is used. | |||
| Namespace string `json:"namespaces,omitempty"` | |||
| Namespace string `json:"namespace,omitempty"` | |||
lkysow
approved these changes
Oct 23, 2020
Co-authored-by: Iryna Shustava <[email protected]>
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Document envoy version requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR: Deployed it in local cluster and viewed the changes. Wasn't sure what a failing test case would look like for this particular error so I would like some feedback on that. Maybe just a standalone test for service-defaults with service splitters? Most of the existing tests test every config entry but that assertion will probably not be the case here.
Checklist: