-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET-6232] Helm Chart: Support StatefulSet PVC retention #3180
Merged
zalimeni
merged 1 commit into
main
from
zalimeni/alemuro/3101-support-statefulset-pvc-retain
Nov 8, 2023
Merged
[NET-6232] Helm Chart: Support StatefulSet PVC retention #3180
zalimeni
merged 1 commit into
main
from
zalimeni/alemuro/3101-support-statefulset-pvc-retain
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
force-pushed
the
zalimeni/alemuro/3101-support-statefulset-pvc-retain
branch
from
November 7, 2023 21:13
e0efe5d
to
622ffa9
Compare
2 tasks
zalimeni
added
backport/1.1.x
Backport to release/1.1.x branch
backport/1.2.x
This release branch is no longer active.
backport/1.3.x
labels
Nov 7, 2023
david-yu
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming tests pass
Rebased to pick up fix from #3172, which should address unit test failure |
Add new variable on the Helm chart to define the PVC retention policy for the StatefulSet
zalimeni
force-pushed
the
zalimeni/alemuro/3101-support-statefulset-pvc-retain
branch
from
November 8, 2023 14:44
622ffa9
to
3cddf31
Compare
zalimeni
deleted the
zalimeni/alemuro/3101-support-statefulset-pvc-retain
branch
November 8, 2023 15:17
This was referenced Nov 8, 2023
Merged
Merged
zalimeni
changed the title
[NET-5025] Helm Chart: Support StatefulSet PVC retention
[NET-6232] Helm Chart: Support StatefulSet PVC retention
Nov 8, 2023
4 tasks
4 tasks
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
Helm Chart: Support StatefulSet PVC retention Add new variable on the Helm chart to define the PVC retention policy for the StatefulSet Co-authored-by: Aleix Murtra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.1.x
Backport to release/1.1.x branch
backport/1.2.x
This release branch is no longer active.
backport/1.3.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to run CI and then merge the following community contribution by @alemuro: #3102
Refer to that PR for discussion and examples.