Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patch for validating webhook #314

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Remove patch for validating webhook #314

merged 1 commit into from
Aug 28, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Aug 28, 2020

There is no validating webhook anymore.

@lkysow lkysow requested a review from thisisnotashwin August 28, 2020 17:02
thisisnotashwin
thisisnotashwin approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅 👀

@lkysow lkysow merged commit c89e4d2 into crd-controller-base Aug 28, 2020
@lkysow lkysow deleted the remove-validating-webhook branch August 28, 2020 17:39
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this pull request Jul 9, 2021
@lkysow
Merge pull request hashicorp#314 from hashicorp/lifecycle-sidecar
272764a 
Add -consul-k8s-image flag to injector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@kschoche kschoche kschoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkysow @kschoche @thisisnotashwin